-
Notifications
You must be signed in to change notification settings - Fork 34k
fix(neo-tree): allow neo-tree to hijack netrw on startup #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dam9000
approved these changes
Apr 23, 2025
oriori1703
approved these changes
Apr 23, 2025
arsxhy
pushed a commit
to arsxhy/arsKickstart.nvim
that referenced
this pull request
May 11, 2025
dribic
pushed a commit
to dribic/nvim-files
that referenced
this pull request
May 11, 2025
…a#1489) Signed-off-by: Dejan Ribič <dejan.ribic@gmail.com>
kumiau
pushed a commit
to kumiau/kickstart.nvim
that referenced
this pull request
May 12, 2025
viliusradz
pushed a commit
to viliusradz/kickstart.nvim
that referenced
this pull request
May 14, 2025
CamilleMo
pushed a commit
to CamilleMo/kickstart.nvim
that referenced
this pull request
May 16, 2025
DivyanshDev05
pushed a commit
to DivyanshDev05/kickstart.nvim
that referenced
this pull request
May 17, 2025
kuroikyu
pushed a commit
to kuroikyu/kickstart.nvim
that referenced
this pull request
May 18, 2025
mhamza15
added a commit
to mhamza15/kickstart.nvim
that referenced
this pull request
May 19, 2025
* Added lua/lazy-bootstrap.lua * Added lua/lazy-plugins.lua * Added lua/options.lua * Added lua/keymaps.lua * Added lua/telescope-setup.lua * Added lua/treesitter-setup.lua * Added lua/lsp-setup.lua * Added lua/cmp-setup.lua * Update README.md - remove single-file * Update README.md - kickstart-modular fork * init.lua: update section comments to match upstream * Run stylua on init.lua * Minor changes to README to reflect the modular repo (nvim-lua#3) * Update README to reflect modular organization - Change install links to this repo instead of nvim-lua/kickstart.nvim - Change “Recommended Steps” repo link to reflect kickstart-modular.nvim.git - Change FAQ re: multiple files to reflect that we are in the modular repo, not the single file repo. * README.md: removed some trailing spaces * fix: incorrect reference to init.lua in README.md * README.md: minor update to the modular fork note * chore(docs): Update README.md (nvim-lua#1344) Neovim has renamed the "linux64" binary to "linux-x86_64". * docs: clarify using opts = {} vs config = function() ... require('plu… (nvim-lua#1316) * docs: clarify using opts = {} vs config = function() ... require('plugin').setup({}) .. end The current documentation mentioning that using "require" is equivalent to using "opts" without detailing the use in the "config = function()" block seems inaccurate. Lower in the configuration the "config = function()" block is used without clarifying why it needed and what it does. This clarification may help new users understand the difference between the two, or how and where to place the "require" statement. * Update init.lua * remove whitespace * fix (nvim-lua#1319): gitsigns deprecated functions (nvim-lua#1321) - This commit change two functions that are marked as deprecated now: `gitsigns.stage_hunk` and `gitsigns.toggle_deleted` * Add a blurb about installing missing emoji on Ubuntu Right next to the nerdfonts blurb as requested. * fix: arguments for the `vim.lsp.Client.supports_method` method (nvim-lua#1356) * feat(diagnostic): add diagnostic config (nvim-lua#1335) Co-authored-by: gelocraft <gelocraft@users.noreply.github.com> * perf: load tokyonight.nvim in the intended way (nvim-lua#1360) Fixes nvim-lua#1357 * feat: add basic function signature help (nvim-lua#1358) * feat: add basic function signature help * Update init.lua Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com> --------- Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com> * Fix: fix the cmp-nvim-lsp-signature-help link (nvim-lua#1363) * fix: regression introduced in db78c0b (nvim-lua#1367) * Remove duplicate cmp-path (nvim-lua#1369) * Propsed fix for init.lua warnings as per nvim-lua#1305 (comment) (nvim-lua#1354) * feat: add `vim.opt.confirm = true` (nvim-lua#1384) * fix: use correct github abmonition syntax (nvim-lua#1414) * changed Conform's format_on_save lambda so that buffers that match disable_filetypes return nil. This allows you to enable a formatter for langages in the disable_filetypes table to have a formatter that can be run manually with Leader-f but doesnt enable format_on_save for them (nvim-lua#1395) * feat(keymap): move windows without `<C-w>` (nvim-lua#1368) * fix: minor misspellings (nvim-lua#1450) * fix: minor misspellings * revert change for `-Bbuild` * Change LSP Keybindings to Match the Default `gr` Bindings Introduced in Neovim 0.11 (nvim-lua#1427) * refactor: change LSP keybindings to the default gr bindings introduced in 0.11 * refactor: modify existing LSP functions to follow convention * Remove Telescope `0.1` branch lock (nvim-lua#1448) * feat: switch nvim-cmp for blink.cmp (nvim-lua#1426) * remove cmp.lua which was replaced with blink-cmp.lua * Change to Mason's new address (nvim-lua#1516) * feat: switch vim-sleuth for guess-indent.nvim (nvim-lua#1512) * Replace vim.opt with vim.o (nvim-lua#1495) * Replace vim.opt with vim.o Because it offers a nicer interface and info on hover. For now leave vim.opt when using the table interface (until vim.o with tables is implemented) * Add type hint for vim.opt.rtp * Add a comment about using vim.opt instead of vim.o * don't lazy-load neo-tree so netrw hijacking on startup works (nvim-lua#1489) * README: mention fd-find in requirements (nvim-lua#1477) Fixes nvim-lua#1476 * fix: rename vim.highlight.on_yank to vim.hl.on_yank (nvim-lua#1482) The functions of vim.highlight were renamed to vim.hl on commit 18b43c331d8a0ed87d7cbefe2a18543b8e4ad360 of neovim, which was applied with the release of nvim version 0.11. Now, the use of vim.highlight is deprecated, and instead, one should use vim.hl functions. In practice, vim.highlight is still working, however, asking for help for vim.highlight.on_yank fails (E149), while asking for help for vim.hl.on_yank works as expected. So, by updating the used function, a new user will have easier time looking getting the relevant help. Co-authored-by: Omri Sarig <omri.sarig@prevas.dk> * Update windows installation command * remove conflicting stuff * more changes * more --------- Co-authored-by: Damjan 9000 <damjan.9000@gmail.com> Co-authored-by: Peter S. Jaglom <145091604+pjaglom@users.noreply.github.com> Co-authored-by: Vinit Neogi <20491952+vneogi199@users.noreply.github.com> Co-authored-by: Ryan Nevius <rnevius@users.noreply.github.com> Co-authored-by: bleacheda <60625523+bleacheda@users.noreply.github.com> Co-authored-by: Erlan Rangel <erlanrangel@gmail.com> Co-authored-by: Chris Patti <feoh@feoh.org> Co-authored-by: Jonas Zeltner <jonas.zeltner@posteo.de> Co-authored-by: GeloCraft <115651305+gelocraft@users.noreply.github.com> Co-authored-by: gelocraft <gelocraft@users.noreply.github.com> Co-authored-by: Joaquín Guerra <joaquinguerratocino@gmail.com> Co-authored-by: Rob <rcsfletcher@protonmail.com> Co-authored-by: makeworld <25111343+makew0rld@users.noreply.github.com> Co-authored-by: Aryan Rajoria <57455619+aryan-rajoria@users.noreply.github.com> Co-authored-by: Ari Pollak <aripollak@users.noreply.github.com> Co-authored-by: Crypto-Spartan <29098151+Crypto-Spartan@users.noreply.github.com> Co-authored-by: Luca Saccarola <96259932+saccarosium@users.noreply.github.com> Co-authored-by: RulentWave <49258216+RulentWave@users.noreply.github.com> Co-authored-by: Sander <info@mesander.com> Co-authored-by: dasvh <dasvh@protonmail.com> Co-authored-by: Theo P. <63016528+theopn@users.noreply.github.com> Co-authored-by: Dmytro Onypko <vaporif@gmail.com> Co-authored-by: Liam Dyer <liamcdyer@gmail.com> Co-authored-by: guru245 <guru245@users.noreply.github.com> Co-authored-by: Ori Perry <48057913+oriori1703@users.noreply.github.com> Co-authored-by: pynappo <lehtien.david@gmail.com> Co-authored-by: Omri Sarig <omri.sarig13@gmail.com> Co-authored-by: Omri Sarig <omri.sarig@prevas.dk> Co-authored-by: jaho5 <ho.jason.main@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, Neo-tree maintainer here.
The Neo-tree spec here has an issue where it lazyloads neo-tree and thus stops neo-tree from being able to hijack netrw until the user opens Neo-tree. this seems like inconsistent behavior from a user perspective.
On recent versions of Neo-tree, manual user-side lazyloading for neo-tree is pretty much unnecessary (all the expensive setup work is delayed until Neo-tree is opened or the command is typed, so startup times should be very minimal when not hijacking on startup), so i'd like to remove the lazyloading here such that users get the intended experience.